Skip to main content

Why doesn't Iterator work for my collection?

Let's take a look at the following code:
class Program {
  public static void main(String args[]) {
    ArrayList alist = new ArrayList();
    alist.add(new String("A"));
    alist.add(new String("B"));
    alist.add(new String("C"));
    int i = 0;
    for (Iterator it = alist.iterator(); it.hasNext(); ) {
      System.out.println(alist.get(i++));
    }
  }
}
A runtime exception java.lang.IndexOutOfBoundsException is thrown when it goes beyond the end.

What is wrong? The code combines the iterator and index. After hasNext() returns true, the only way to advance the iterator is to call next(). But the element is retrieved with get(index), so the iterator is never advanced. In the above example, the hasNext() will always be true, and eventually the index i for get(index) will beyond the end of ArrayList.


Do not mix up the iterator and the index. Let's change the above code to fix the problem:
class Program {
  public static void main(String args[]) {
    ArrayList alist = new ArrayList();
    alist.add(new String("A"));
    alist.add(new String("B"));
    alist.add(new String("C"));
    for (Iterator it = alist.iterator(); it.hasNext(); ) {
      System.out.println(it.next());
    }
  }
}
or
class Program {
  public static void main(String args[]) {
    ArrayList alist = new ArrayList();
    alist.add(new String("A"));
    alist.add(new String("B"));
    alist.add(new String("C"));
    for (int i=0; i != alist.size(); i++) {
      System.out.println(alist.get(i));
    }
  }
}

Comments

Popular posts from this blog

Asynchronous Vs. Synchronous Communications

Synchronous (One thread):   1 thread -> |<---A---->||<----B---------->||<------C----->| Synchronous (multi-threaded):   thread A -> |<---A---->| \ thread B ------------> ->|<----B---------->| \ thread C ----------------------------------> ->|<------C----->|

WebSphere MQ Interview Questions

What is MQ and what does it do? Ans. MQ stands for MESSAGE QUEUEING. WebSphere MQ allows application programs to use message queuing to participate in message-driven processing. Application programs can communicate across different platforms by using the appropriate message queuing software products. What is Message driven process? Ans . When messages arrive on a queue, they can automatically start an application using triggering. If necessary, the applications can be stopped when the message (or messages) have been processed. What are advantages of the MQ? Ans. 1. Integration. 2. Asynchrony 3. Assured Delivery 4. Scalability. How does it support the Integration? Ans. Because the MQ is independent of the Operating System you use i.e. it may be Windows, Solaris,AIX.It is independent of the protocol (i.e. TCP/IP, LU6.2, SNA, NetBIOS, UDP).It is not required that both the sender and receiver should be running on the same platform What is Asynchrony? Ans. With messag...

Advantages & Disadvantages of Synchronous / Asynchronous Communications?

  Asynchronous Communication Advantages: Requests need not be targeted to specific server. Service need not be available when request is made. No blocking, so resources could be freed.  Could use connectionless protocol Disadvantages: Response times are unpredictable. Error handling usually more complex.  Usually requires connection-oriented protocol.  Harder to design apps Synchronous Communication Advantages: Easy to program Outcome is known immediately  Error recovery easier (usually)  Better real-time response (usually) Disadvantages: Service must be up and ready. Requestor blocks, held resources are “tied up”.  Usually requires connection-oriented protocol