Skip to main content

Why doesn't Iterator work for my collection?

Let's take a look at the following code:
class Program {
  public static void main(String args[]) {
    ArrayList alist = new ArrayList();
    alist.add(new String("A"));
    alist.add(new String("B"));
    alist.add(new String("C"));
    int i = 0;
    for (Iterator it = alist.iterator(); it.hasNext(); ) {
      System.out.println(alist.get(i++));
    }
  }
}
A runtime exception java.lang.IndexOutOfBoundsException is thrown when it goes beyond the end.

What is wrong? The code combines the iterator and index. After hasNext() returns true, the only way to advance the iterator is to call next(). But the element is retrieved with get(index), so the iterator is never advanced. In the above example, the hasNext() will always be true, and eventually the index i for get(index) will beyond the end of ArrayList.


Do not mix up the iterator and the index. Let's change the above code to fix the problem:
class Program {
  public static void main(String args[]) {
    ArrayList alist = new ArrayList();
    alist.add(new String("A"));
    alist.add(new String("B"));
    alist.add(new String("C"));
    for (Iterator it = alist.iterator(); it.hasNext(); ) {
      System.out.println(it.next());
    }
  }
}
or
class Program {
  public static void main(String args[]) {
    ArrayList alist = new ArrayList();
    alist.add(new String("A"));
    alist.add(new String("B"));
    alist.add(new String("C"));
    for (int i=0; i != alist.size(); i++) {
      System.out.println(alist.get(i));
    }
  }
}

Comments

Popular posts from this blog

Java Health Center - Overview and Features

This video highlights the features available in Health Center. Health Center is a low-processor and memory usage diagnostic tool for monitoring the status of a running IBM Java Virtual Machine (JVM). Health Center provides live information and recommendations in each of the following areas: - Classes: information about classes being loaded - Environment: details of the configuration and system of the monitored application - Garbage Collection: information about the Java heap and pause times - Locking: information about contention on inflated locks - Profiling: sampling profile of Java methods including call paths

WebSphere MQ Interview Questions

What is MQ and what does it do? Ans. MQ stands for MESSAGE QUEUEING. WebSphere MQ allows application programs to use message queuing to participate in message-driven processing. Application programs can communicate across different platforms by using the appropriate message queuing software products. What is Message driven process? Ans . When messages arrive on a queue, they can automatically start an application using triggering. If necessary, the applications can be stopped when the message (or messages) have been processed. What are advantages of the MQ? Ans. 1. Integration. 2. Asynchrony 3. Assured Delivery 4. Scalability. How does it support the Integration? Ans. Because the MQ is independent of the Operating System you use i.e. it may be Windows, Solaris,AIX.It is independent of the protocol (i.e. TCP/IP, LU6.2, SNA, NetBIOS, UDP).It is not required that both the sender and receiver should be running on the same platform What is Asynchrony? Ans. With messag...

Java Garbage Collection

Explain Garbage collection mechanism in Java? Garbage collection is one of the most important features of Java. The purpose of garbage collection is to identify and discard objects that are no longer needed by a program so that their resources can be reclaimed and reused. A Java object is subject to garbage collection when it becomes unreachable to the program in which it is used. Garbage collection is also called automatic memory management as JVM automatically removes the unused variables/objects (value is null) from the memory. Every class inherits finalize() method from java.lang.Object, the finalize() method is called by garbage collector when it determines no more references to the object exists. In Java, it is good idea to explicitly assign null into a variable when no more in use. In Java on calling System.gc() and Runtime.gc(), JVM tries to recycle the unused objects, but there is no guarantee when all the objects will garbage collected. Garbage collection is an automatic pro...